Skip to content

Backport PR #39065 on branch 1.2.x (Regression in replace raising ValueError for bytes object) #39075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2021
Merged

Backport PR #39065 on branch 1.2.x (Regression in replace raising ValueError for bytes object) #39075

merged 1 commit into from
Jan 10, 2021

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #39065: Regression in replace raising ValueError for bytes object

@lumberbot-app lumberbot-app bot added this to the 1.2.1 milestone Jan 9, 2021
@jreback jreback added the Dtype Conversions Unexpected or buggy dtype conversions label Jan 9, 2021
@phofl
Copy link
Member

phofl commented Jan 10, 2021

Failure is caused by xlrd version fixed in #39077 and #39078

@jreback
Copy link
Contributor

jreback commented Jan 10, 2021

Failure is caused by xlrd version fixed in #39077 and #39078

yes these are totally fine. just waiting for the backport to pass first (the fix)

@jreback jreback merged commit c65904e into pandas-dev:1.2.x Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@meeseeksmachine @phofl @jreback